Skip to content

Conversation

@NordicBuilder
Copy link
Contributor

Created from: latest/sub/softdevice_controller_build/v2.6-branch #41.

Signed-off-by: Vinayak Chettimada [email protected]

@NordicBuilder NordicBuilder requested a review from a team as a code owner October 3, 2025 10:42
@CLAassistant
Copy link

CLAassistant commented Oct 3, 2025

CLA assistant check
All committers have signed the CLA.

@cvinayak
Copy link

Compliance check failure due to:

Traceback (most recent call last):
  File "/home/runner/work/sdk-nrfxlib/sdk-nrfxlib/ncs/zephyr/scripts/ci/check_compliance.py", line 26, in <module>
    from dotenv import load_dotenv
[ModuleNotFoundError: No module named 'dotenv'](https://github.com/nrfconnect/sdk-nrfxlib/actions/runs/18724767866/job/53406349944?pr=1870#step:6:67)

This will need a rebase? but do not want to rebase old release branches.

Fixing failing compliance workflow.

Signed-off-by: Kari Hamalainen <[email protected]>
(cherry picked from commit 0b418d1)
Signed-off-by: Chettimada, Vinayak <[email protected]>
@cvinayak cvinayak requested a review from laxiLang October 23, 2025 11:15
@sonarqubecloud
Copy link

@cvinayak cvinayak requested a review from carlescufi October 23, 2025 12:11
@cvinayak
Copy link

@carlescufi should I remove the cherry-pick commit I added to get compliance working? any issue in having this change to the branch in how python dependencies are picked?

@cvinayak cvinayak changed the title Update MPSL and SoftDevice Controller [v2.6.4-NCSDK-34113-branch] Update MPSL and SoftDevice Controller Oct 23, 2025
@carlescufi
Copy link
Contributor

@carlescufi should I remove the cherry-pick commit I added to get compliance working? any issue in having this change to the branch in how python dependencies are picked?

no, this is fine

@carlescufi carlescufi merged commit c6b81f4 into nrfconnect:v2.6.4-NCSDK-34113-branch Oct 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants